Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7adeb91c0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def check_mytonctrl_update(local): | ||
| git_path = local.buffer.my_dir | ||
| def check_mytonctrl_update(local: MyPyClass): | ||
| git_path = '/usr/src/mytonctrl' |
There was a problem hiding this comment.
Use of a fixed git_path = '/usr/src/mytonctrl' breaks update checks for deployments where mytonctrl is installed elsewhere (for example via pip/venv or a custom checkout path). check_git_update executes git commands with that path as cwd; if the directory is absent, it raises and pre_up logs an error on each run while silently skipping update detection. This should derive the path from runtime location (or at least check existence before calling git).
Useful? React with 👍 / 👎.
1 participant
No description provided.